sferik / t / 997

95%

Pull #369

travis-ci

Two new Rubocop directives

1. Metrics/BlockLength disabled for the spec directory.  Prior to this change, you get a bunch of failures like:

    ```
    spec/set_spec.rb:5:1: C: Block has too many lines. [138/25]
    describe T::Set do ...
    ^^^^^^^^^^^^^^^^^^
    ```

    The blocklength validation doesn’t really make sense when assessing files written with the RSpec DSL, since when written properly, the specs are just very long blocks themselves.

2. Disable Style/IndentHeredoc.  For Ruby 2.3+, the recommendation from Rubocop is just to use `<<~` or to use "some library (e.g. ActiveSupport's String#strip_heredoc)" for earlier versions of Ruby.

    However, the places that heredocs are being used are to test the output, and those are actually testing the spacing itself explicitly, so it doesn't make sense to squish the indentation out when it's present in this case anyway.

56 of 56 new or added lines in 7 files covered. (100.0%)

1706 of 1718 relevant lines covered (99.3%)

312.55 hits per line