marshallward / f90nml / 289
99%

DEFAULT BRANCH: master
Ran
Jobs 8
Files 7
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
289

push

travis-ci

marshallward 
CLI JSON/YAML support, complex list bugfix, print

Several changes in this patch:

- dicts now include certain metadata to support conversion from `dict`
  to Namelist and vice versa.  This is primarily to support further
  conversion to other formats.

  Currently only includes complex variables (converted to 2-element lists) and
  starting index for arrays.  This could be extended to the formatting
  properties.

- In the same vein, a `todict` function was created to convert the Namelist
  back to a standard Python `dict`.  This `dict` includes the metadata
  mentioned in the previous comment.

- This metadata is used to when reading a `dict` for conversion to `Namelist`.

- Improved support for JSON and YAML conversion.  One-to-one conversion appears
  to work so far.

   - Tests still missing here.  (A broken JSON test is in comments)
   - YAML now uses `safe_load`, to prevent and manage foreign objects
   - JSON reading preserves order, but is not handled in writes or YAML reads

And for some completely unrelated updates...

- Arrays of complex numbers could not be parsed due to a bug in the parser.  We
  were only looking for initial value pairs '=(' but not additional values
  ',('.  This case was added, and it appears to work correctly.

- Intrinsic __str__ support, so that print() now gives namelist-like
  output

   - As part of this, most of `write` was moved to a `writestream` method,
     similar to `read` and `readstream`.

- Finally, test cases were formatted a little more consistently, and the 2/3
  stringIO object issue is handled a little more cleanly now.  We use the
  StringIO.StringIO object in 2.x rather than io.BytesIO, since
  StringIO.StringIO can support either unicode or bytes.  (Note this does not
  exist in 3.x, so in this case we use io.StringIO).

  A similar strategy was used in __str__(), which inspired this change.

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an e... (continued)

845 of 918 relevant lines covered (92.05%)

7.32 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
20
56.25
 -1.93% /home/travis/build/marshallward/f90nml/f90nml/cli.py
44
84.45
 -15.11% /home/travis/build/marshallward/f90nml/f90nml/namelist.py
Jobs
ID Job ID Ran Files Coverage
1 289.1 7
91.83
 Travis Job 289.1
2 289.2 7
91.39
 Travis Job 289.2
4 289.4 7
91.5
 Travis Job 289.4
5 289.5 7
91.5
 Travis Job 289.5
6 289.6 7
91.5
 Travis Job 289.6
7 289.7 7
91.5
 Travis Job 289.7
8 289.8 7
91.29
 Travis Job 289.8
9 289.9 7
91.39
 Travis Job 289.9
Source Files on build 289
Coverage ∆ File Lines Relevant Covered Missed Hits/Line