graphql / graphql-js / 2759

98%

push

travis-ci

Test: Missing subscription field should not be an "internal error" (#1106)

A remaining issue with subscriptions is attempting to subscribe to a missing field. The existing implementation creates an internal error which is an improper blame since there is no possibility to fix it internally - it is an issue with the query.

Since there is no clear consistent behavior relative to query/mutation operations (which simply skip over unknown fields), and the corner-case where this occurs should deal with the error - this changes the internal error to an external yielded GraphQL error.

Note: we still require a spec change since there is an ambiguity of this exact scenario.

3875 of 4360 branches covered (88.88%)

9442 of 9552 relevant lines covered (98.85%)

1304.93 hits per line