6917
37%

Ran 05 Dec 2017 03:02AM UTC

Jobs 1

Files 262

Run time 177141min

Badge

Embed ▾

pending completion

Build # 6917

Build Type

Pull #2138

travis-ci

Committed by

web-flow

Commit Message

curl_sspi: Use Unicode identity in non-UNICODE SSPI builds

- Make it so SSPI non-UNICODE builds can handle Unicode user/pass.

Prior to this change those builds basically attempted to create an
identity in the local codepage but that didn't work.

In more detail, what was expected to be a UTF-8 user/pass supplied by
the user was incorrectly treated as ANSI (ie user's local codepage),
which would cause AcquireCredentialsHandleA to fail at some later point
due to the incorrect encoding. Of note is even if the user tried ANSI
encoding for the user/pass (which may or may not be perceived as correct
since we don't document it), empirical testing has shown the conversion
would not necessarily be successful anyway (In other words it would be
incorrect to assume that internally Windows was doing a conversion from
ANSI -> UTF-16 like it does for most ANSI functions). See #2120 for more
information.

Ref: https://github.com/curl/curl/issues/2120

Pull Request Pull Request #2138: curl_sspi: Use Unicode identity in non-UNICODE SSPI builds

Run Details

19450 of 25967 relevant lines covered (74.9%)

181617.6 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	84.44	-0.25%	lib/imap.c
19	70.77	-5.44%	lib/rtsp.c

Jobs

ID	Job ID	Ran	Files	Coverage
16	6917.16 (T=coverage)	05 Dec 2017 03:02AM UTC	262	74.9	Travis Job 6917.16

Source Files on build 6917

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

curl / curl / 6917
37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 6917

curl / curl / 6917 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 6917

curl / curl / 6917
37%

README BADGES
x