graphql / graphql-js / 2693

98%

push

travis-ci

Fix infinite loop on invalid queries in OverlappingFields (#1111)

`OverlappingFieldsCanBeMerged` would infinite loop when passed something like

```graphql
fragment A on User {
  name
  ...A
}
```

It's not `OverlappingFieldsCanBeMerged`'s responsibility to detect that validation error, but we still would ideally avoid infinite looping.

This detects that case, and pretends that the infinite spread wasn't there for the purposes of this validation step.

Also, by memoizing and checking for self-references this removes duplicate reports.

Closes #780

3874 of 4359 branches covered (88.87%)

9442 of 9553 relevant lines covered (98.84%)

1289.89 hits per line