openmrs / openmrs-core / 5977
65%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 601
Run time 34s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5977

Pull #2366

travis-ci

web-flow 
Fix bad code practises
Pull Request #2366: [GCI-142] Check bad code practices through Findbugs or Sonar and fix those issues.

1500 of 1500 new or added lines in 228 files covered. (100.0%)

18155 of 31996 relevant lines covered (56.74%)

0.57 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
82.22
 0.0% api/src/main/java/org/openmrs/BaseCustomizableData.java
1
82.22
 0.0% api/src/main/java/org/openmrs/BaseCustomizableMetadata.java
1
93.28
 1.37% api/src/main/java/org/openmrs/DrugOrder.java
1
69.05
 0.0% api/src/main/java/org/openmrs/Field.java
1
77.85
 0.0% api/src/main/java/org/openmrs/Location.java
1
88.37
 0.0% api/src/main/java/org/openmrs/OrderSet.java
1
60.36
 -0.7% api/src/main/java/org/openmrs/Patient.java
1
88.89
 2.4% api/src/main/java/org/openmrs/PatientIdentifier.java
1
77.86
 0.0% api/src/main/java/org/openmrs/PatientProgram.java
1
83.16
 1.71% api/src/main/java/org/openmrs/PersonAttribute.java
1
66.04
 0.0% api/src/main/java/org/openmrs/Program.java
1
51.52
 0.09% api/src/main/java/org/openmrs/annotation/AuthorizedAnnotationAttributes.java
1
85.05
 0.0% api/src/main/java/org/openmrs/api/db/hibernate/ChainingInterceptor.java
1
89.8
 0.0% api/src/main/java/org/openmrs/api/db/hibernate/HibernateLocationDAO.java
1
95.12
 0.0% api/src/main/java/org/openmrs/api/db/hibernate/HibernatePersonDAO.java
1
91.84
 0.0% api/src/main/java/org/openmrs/api/handler/ExistingOrNewVisitAssignmentHandler.java
1
89.19
 0.0% api/src/main/java/org/openmrs/api/impl/DatatypeServiceImpl.java
1
70.87
 -0.13% api/src/main/java/org/openmrs/api/impl/FormServiceImpl.java
1
42.5
 0.0% api/src/main/java/org/openmrs/api/impl/SerializationServiceImpl.java
1
0.0
 0.0% api/src/main/java/org/openmrs/hl7/HL7InQueueProcessor.java
1
0.0
 0.0% api/src/main/java/org/openmrs/hl7/Hl7InArchivesMigrateThread.java
1
0.0
 0.0% api/src/main/java/org/openmrs/logic/Duration.java
1
48.57
 -2.78% api/src/main/java/org/openmrs/messagesource/impl/CachedMessageSource.java
1
6.94
 0.0% api/src/main/java/org/openmrs/notification/impl/MessageServiceImpl.java
1
0.0
 0.0% api/src/main/java/org/openmrs/notification/mail/MailMessageSender.java
1
72.28
 -0.27% api/src/main/java/org/openmrs/propertyeditor/ConceptAnswersEditor.java
1
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/tasks/AutoCloseVisitsTask.java
1
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/tasks/ProcessHL7InQueueTask.java
1
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/tasks/SendEmailTask.java
1
82.61
 -0.49% api/src/main/java/org/openmrs/util/Graph.java
1
0.0
 0.0% api/src/main/java/org/openmrs/util/OpenmrsMemento.java
1
23.81
 -1.19% api/src/main/java/org/openmrs/util/UpgradeUtil.java
1
0.0
 0.0% api/src/main/java/org/openmrs/util/VelocityExceptionHandler.java
1
0.0
 0.0% api/src/main/java/org/openmrs/util/databasechange/DisableTriggersChangeSet.java
1
0.0
 0.0% api/src/main/java/org/openmrs/util/databasechange/EnableTriggersChangeSet.java
1
8.57
 0.46% api/src/main/java/org/openmrs/util/databasechange/EncryptSecretAnswersChangeSet.java
1
9.68
 0.2% api/src/main/java/org/openmrs/util/databasechange/GenerateUuid.java
1
1.71
 0.0% api/src/main/java/org/openmrs/util/databasechange/MigrateConceptReferenceTermChangeSet.java
1
4.17
 0.17% api/src/main/java/org/openmrs/util/databasechange/MigrateDrugOrderFrequencyToCodedOrderFrequencyChangeset.java
1
4.26
 0.17% api/src/main/java/org/openmrs/util/databasechange/MigrateDrugOrderUnitsToCodedDoseUnitsChangeset.java
1
5.26
 -2.05% api/src/main/java/org/openmrs/util/databasechange/MoveDeletedHL7sChangeSet.java
1
9.09
 0.52% api/src/main/java/org/openmrs/util/databasechange/UpdateLayoutAddressFormatChangeSet.java
1
0.0
 0.0% web/src/main/java/org/openmrs/module/web/ModuleResourcesServlet.java
1
0.0
 0.0% web/src/main/java/org/openmrs/module/web/WebModuleUtil.java
1
0.0
 0.0% web/src/main/java/org/openmrs/module/web/filter/ModuleFilter.java
1
0.0
 0.0% web/src/main/java/org/openmrs/module/web/filter/ModuleFilterConfig.java
1
0.0
 0.0% web/src/main/java/org/openmrs/module/web/filter/ModuleFilterDefinition.java
1
0.0
 0.0% web/src/main/java/org/openmrs/web/DispatcherServlet.java
1
0.0
 0.0% web/src/main/java/org/openmrs/web/StaticDispatcherServlet.java
1
0.0
 0.0% web/src/main/java/org/openmrs/web/filter/OpenmrsFilter.java
2
73.58
 0.0% api/src/main/java/org/openmrs/Cohort.java
2
47.37
 -0.68% api/src/main/java/org/openmrs/ProgramWorkflow.java
2
76.67
 0.16% api/src/main/java/org/openmrs/User.java
2
31.03
 0.0% api/src/main/java/org/openmrs/aop/LoggingAdvice.java
2
76.32
 4.71% api/src/main/java/org/openmrs/api/db/hibernate/HibernateSessionFactoryBean.java
2
81.86
 0.0% api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java
2
0.0
 0.0% api/src/main/java/org/openmrs/logic/LogicTransform.java
2
53.33
 0.0% api/src/main/java/org/openmrs/module/AdvicePoint.java
2
0.0
 0.0% api/src/main/java/org/openmrs/module/Extension.java
2
66.67
 2.26% api/src/main/java/org/openmrs/obs/handler/AbstractHandler.java
2
13.89
 0.0% api/src/main/java/org/openmrs/obs/handler/BinaryStreamHandler.java
2
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/timer/TimerSchedulerMemento.java
2
0.0
 0.0% api/src/main/java/org/openmrs/util/AttributableDate.java
2
0.0
 0.0% api/src/main/java/org/openmrs/util/MemoryLeakUtil.java
2
59.41
 -1.17% api/src/main/java/org/openmrs/util/Security.java
2
0.0
 0.0% api/src/main/java/org/openmrs/util/databasechange/CheckDrugOrderUnitAndFrequencyTextNotMappedToConcepts.java
2
4.17
 0.17% api/src/main/java/org/openmrs/util/databasechange/ConvertOrderersToProviders.java
2
4.08
 0.16% api/src/main/java/org/openmrs/util/databasechange/CreateCodedOrderFrequencyForDrugOrderFrequencyChangeset.java
2
3.57
 -1.69% api/src/main/java/org/openmrs/util/databasechange/ProgramValidatorChangeSet.java
2
5.15
 0.0% api/src/main/java/org/openmrs/util/databasechange/SourceMySqldiffFile.java
3
87.14
 0.0% api/src/main/java/org/openmrs/Person.java
3
9.16
 -0.54% api/src/main/java/org/openmrs/api/db/hibernate/HibernateSerializedObjectDAO.java
3
65.91
 0.0% api/src/main/java/org/openmrs/layout/LayoutTemplate.java
3
0.0
 0.0% api/src/main/java/org/openmrs/logic/op/LogicalOperator.java
3
70.51
 1.9% api/src/main/java/org/openmrs/module/Module.java
3
52.79
 0.35% api/src/main/java/org/openmrs/module/ModuleUtil.java
3
47.17
 -2.83% api/src/main/java/org/openmrs/obs/handler/ImageHandler.java
3
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/tasks/CheckInternetConnectivityTask.java
3
0.0
 0.0% api/src/main/java/org/openmrs/util/MemoryAppender.java
3
15.31
 0.31% web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java
3
0.0
 0.0% web/src/main/java/org/openmrs/web/filter/util/CustomResourceLoader.java
4
70.54
 -0.12% api/src/main/java/org/openmrs/api/db/hibernate/HibernateEncounterDAO.java
4
44.91
 0.21% api/src/main/java/org/openmrs/api/db/hibernate/PatientSearchCriteria.java
4
73.52
 0.06% api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java
4
52.64
 0.13% api/src/main/java/org/openmrs/module/ModuleClassLoader.java
4
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/tasks/AlertReminderTask.java
4
21.71
 0.0% api/src/main/java/org/openmrs/scheduler/timer/TimerSchedulerServiceImpl.java
4
0.0
 0.0% api/src/main/java/org/openmrs/util/FormUtil.java
4
51.85
 -5.84% api/src/main/java/org/openmrs/util/Format.java
4
2.35
 0.16% api/src/main/java/org/openmrs/util/databasechange/CreateDiscontinueOrders.java
5
46.55
 0.79% api/src/main/java/org/openmrs/Form.java
5
52.88
 -0.45% api/src/main/java/org/openmrs/api/context/Daemon.java
5
86.73
 -0.04% api/src/main/java/org/openmrs/api/db/hibernate/HibernateConceptDAO.java
5
30.5
 0.64% api/src/main/java/org/openmrs/messagesource/impl/MutableResourceBundleMessageSource.java
6
90.33
 -0.27% api/src/main/java/org/openmrs/api/impl/PersonServiceImpl.java
6
1.69
 0.01% api/src/main/java/org/openmrs/hl7/handler/ADTA28Handler.java
6
10.87
 0.67% api/src/main/java/org/openmrs/obs/handler/BinaryDataHandler.java
6
66.67
 -2.69% api/src/main/java/org/openmrs/obs/handler/TextHandler.java
6
0.0
 0.0% api/src/main/java/org/openmrs/propertyeditor/ConceptSetsEditor.java
7
91.68
 1.41% api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java
7
67.9
 0.0% api/src/main/java/org/openmrs/customdatatype/CustomDatatypeUtil.java
7
0.0
 0.0% api/src/main/java/org/openmrs/logic/op/TransformOperator.java
7
27.73
 0.11% api/src/main/java/org/openmrs/logic/result/Result.java
7
40.7
 0.45% api/src/main/java/org/openmrs/util/DatabaseUtil.java
7
20.54
 0.16% api/src/main/java/org/openmrs/util/OpenmrsConstants.java
8
0.0
 0.0% api/src/main/java/org/openmrs/layout/address/AddressSupport.java
9
81.8
 0.11% api/src/main/java/org/openmrs/Concept.java
9
3.45
 0.0% api/src/main/java/org/openmrs/util/databasechange/DuplicateEncounterTypeNameChangeSet.java
10
0.0
 0.0% api/src/main/java/org/openmrs/logic/op/ComparisonOperator.java
10
0.0
 0.0% api/src/main/java/org/openmrs/migration/MigrationHelper.java
11
57.95
 -0.14% api/src/main/java/org/openmrs/api/impl/AdministrationServiceImpl.java
12
49.29
 0.46% api/src/main/java/org/openmrs/module/ModuleFactory.java
12
3.33
 0.18% api/src/main/java/org/openmrs/util/databasechange/DuplicateEncounterRoleNameChangeSet.java
12
3.33
 0.18% api/src/main/java/org/openmrs/util/databasechange/DuplicateLocationAttributeTypeNameChangeSet.java
14
59.31
 0.61% api/src/main/java/org/openmrs/api/context/ServiceContext.java
14
55.22
 -0.37% api/src/main/java/org/openmrs/module/ModuleFileParser.java
14
10.42
 -0.07% api/src/main/java/org/openmrs/util/databasechange/BooleanConceptChangeSet.java
15
40.36
 0.12% api/src/main/java/org/openmrs/api/context/Context.java
21
0.0
 0.0% api/src/main/java/org/openmrs/logic/op/Operator.java
22
40.0
 0.49% api/src/main/java/org/openmrs/util/DatabaseUpdater.java
24
80.1
 -0.25% api/src/main/java/org/openmrs/Obs.java
24
1.77
 0.06% api/src/main/java/org/openmrs/util/databasechange/AddConceptMapTypesChangeset.java
27
36.89
 0.44% api/src/main/java/org/openmrs/util/OpenmrsClassLoader.java
53
77.65
 -0.44% api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java
67
2.06
 -0.08% api/src/main/java/org/openmrs/util/databasechange/ConceptValidatorChangeSet.java
71
31.7
 0.48% api/src/main/java/org/openmrs/util/OpenmrsUtil.java

Uncovered Existing Lines

Lines Coverage ∆ File
1
77.65
 -0.44% api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java
1
52.64
 0.13% api/src/main/java/org/openmrs/module/ModuleClassLoader.java
1
0.0
 0.0% api/src/main/java/org/openmrs/util/MemoryLeakUtil.java
1
84.51
 -1.6% api/src/main/java/org/openmrs/util/HandlerUtil.java
1
0.0
 0.0% api/src/main/java/org/openmrs/propertyeditor/ConceptSetsEditor.java
1
76.67
 0.16% api/src/main/java/org/openmrs/User.java
1
77.14
 0.0% api/src/main/java/org/openmrs/AllergyReaction.java
1
46.55
 0.79% api/src/main/java/org/openmrs/Form.java
1
10.87
 0.67% api/src/main/java/org/openmrs/obs/handler/BinaryDataHandler.java
1
5.26
 -2.05% api/src/main/java/org/openmrs/util/databasechange/MoveDeletedHL7sChangeSet.java
1
0.0
 0.0% api/src/main/java/org/openmrs/scheduler/tasks/AutoCloseVisitsTask.java
1
87.5
 0.0% api/src/main/java/org/openmrs/api/cache/CachePropertiesUtil.java
1
59.31
 0.61% api/src/main/java/org/openmrs/api/context/ServiceContext.java
1
3.33
 0.18% api/src/main/java/org/openmrs/util/databasechange/DuplicateLocationAttributeTypeNameChangeSet.java
1
97.14
 -0.04% api/src/main/java/org/openmrs/validator/DrugOrderValidator.java
1
15.31
 0.31% web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java
1
73.58
 0.0% api/src/main/java/org/openmrs/Cohort.java
2
55.22
 -0.37% api/src/main/java/org/openmrs/module/ModuleFileParser.java
2
36.89
 0.44% api/src/main/java/org/openmrs/util/OpenmrsClassLoader.java
2
3.33
 0.18% api/src/main/java/org/openmrs/util/databasechange/DuplicateEncounterRoleNameChangeSet.java
3
72.17
 0.0% api/src/main/java/org/openmrs/Allergy.java
3
57.95
 -0.14% api/src/main/java/org/openmrs/api/impl/AdministrationServiceImpl.java
3
40.36
 0.12% api/src/main/java/org/openmrs/api/context/Context.java
3
10.42
 -0.07% api/src/main/java/org/openmrs/util/databasechange/BooleanConceptChangeSet.java
4
93.62
 0.0% api/src/main/java/org/openmrs/api/db/hibernate/HibernateAdministrationDAO.java
5
1.77
 0.06% api/src/main/java/org/openmrs/util/databasechange/AddConceptMapTypesChangeset.java
6
40.0
 0.49% api/src/main/java/org/openmrs/util/DatabaseUpdater.java
8
2.06
 -0.08% api/src/main/java/org/openmrs/util/databasechange/ConceptValidatorChangeSet.java
10
31.7
 0.48% api/src/main/java/org/openmrs/util/OpenmrsUtil.java
17
60.36
 -0.7% api/src/main/java/org/openmrs/Patient.java
18
47.83
 0.0% api/src/main/java/org/openmrs/module/SqlDiffFileParser.java
22
87.14
 0.0% api/src/main/java/org/openmrs/Person.java
25
59.41
 -1.17% api/src/main/java/org/openmrs/util/Security.java
27
6.94
 0.0% api/src/main/java/org/openmrs/notification/impl/MessageServiceImpl.java
28
70.69
 0.0% api/src/main/java/org/openmrs/api/context/UserContext.java
38
70.51
 1.9% api/src/main/java/org/openmrs/module/Module.java
130
20.54
 0.16% api/src/main/java/org/openmrs/util/OpenmrsConstants.java
Jobs
ID Job ID Ran Files Coverage
1 5977.1 601
56.74
 Travis Job 5977.1
Source Files on build 5977
Coverage ∆ File Lines Relevant Covered Missed Hits/Line