629
93%

Ran 09 Nov 2014 04:04PM UTC

Jobs 3

Files 61

Run time 48s

Badge

Embed ▾

pending completion

Build # 629

Build Type

Pull #271

travis-ci

Committed by

andrey-mokhov

Commit Message

changed logic for assertion part

old logic:
1. if identity hasn't roles - no checks for assertions. (why?). return false (no granted)
2. if identity roles don't have a permission - no checks for assertions. (why? WHY?) return false (no granted)
3. checks assertion - no comments, it's ok
4. return true, hmm... ok

new logic:
1. if identity has one or more roles and any role has permission - return true
2. if has assertion - check
3. return false - (no roles with permission and no assertions)

Pull Request Pull Request #271: changed logic for assertion part

Run Details

543 of 591 relevant lines covered (91.88%)

14.51 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	0.0	-100.0%	ZfcRbac/Exception/InvalidArgumentException.php
12	55.56	-44.44%	ZfcRbac/Service/AuthorizationService.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	629.1	09 Nov 2014 04:04PM UTC	61	91.54	Travis Job 629.1
2	629.2	09 Nov 2014 04:04PM UTC	61	91.71	Travis Job 629.2
3	629.3	09 Nov 2014 04:05PM UTC	61	91.71	Travis Job 629.3

Source Files on build 629

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ZF-Commons / zfc-rbac / 629
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 629

ZF-Commons / zfc-rbac / 629 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 629

ZF-Commons / zfc-rbac / 629
93%

README BADGES
x