teppeis / fixclosure / 228

99%

Pull #48

travis-ci

<a href="https://github.com/teppeis/fixclosure/commit/<a class=hub.com/teppeis/fixclosure/commit/<a class="double-link" href="https://git"><a class=hub.com/teppeis/fixclosure/commit/<a class="double-link" href="https://git"><a class=hub.com/teppeis/fixclosure/commit/<a class="double-link" href="https://git"><a class=hub.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c">dca75a790<a href="https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c">&lt;a href=&quot;https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;quot;&amp;amp;gt;Do not provide inner CONSTANT, Class, Enum, TypeDef and static method.

According to official styleguide, we should not provide inner
CONSTANT, Class, Enum, TypeDef and others. Only top-level Class is enough.

https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Providing_Dependencies_With_goog.provide#Providing_Dependencies_With_goog.provide

Squashed commit of the following:

commit &amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/teppeis/fixclosure/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/teppeis/fixclosure/commit/5727eeae5f5bc87663a8ac689b828469659fdba3&amp;quot;&amp;gt;5727eeae5&amp;lt;/a&amp;gt;&amp;quot;&amp;gt;5727eeae5&amp;lt;/a&amp;gt;&amp;lt;a href=&amp;quot;https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c&amp;quot;&amp;gt;
Author: Kengo TODA &amp;amp;lt;skypencil@gmail.com&amp;amp;gt;
Date:   Sun Nov 9 15:05:48 2014 +0800

    create Parser instance at timing of `beforeEach`

commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/teppeis/fixclosure/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/teppeis/fixclosure/commit/7d9185ab5faff1f9fd504770e7ea8c6113ddaec1&quot;&gt;7d9185ab5&lt;/a&gt;&quot;&gt;7d9185ab5&lt;/a&gt;&lt;a href=&quot;https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c&quot;&gt;
Author: Kengo TODA &amp;lt;skypencil@gmail.com&amp;gt;
Date:   Sun Nov 9 14:44:44 2014 +0800

    refactor

commit </a><a class="double-link" href="https://github.com/teppeis/fixclosure/commit/<a class="double-link" href="https://github.com/teppeis/fixclosure/commit/ed7dd24bf27260b919492cff3ea6c7ec5a290808">ed7dd24bf</a>">ed7dd24bf</a><a href="https://github.com/teppeis/fixclosure/commit/dca75a790d2981167d632340f5308f840e50e63c">
Author: Kengo TODA &lt;skypencil@gmail.com&gt;
Date:   Sun Nov 9 14:25:00 2014 +0800

    pass all tests

commit </a><a class="double-link" href="https://github.com/teppeis/fixclosure/commit/<a class="double-link" href="https://github.com/teppeis/fixclosure/commit/c5c5ba4d3d2bee113d6122623461df4d3585fa6c">c5c5ba4d3">c5c5ba4d3
Author: Kengo TODA <skypencil@gmail.com>
Date:   Sat Nov 8 17:41:22 2014 +0800

    implement expected behavior

commit Pull Request #48:
Do not provide inner CONSTANT, Class, Enum, TypeDef and static method.

530 of 536 relevant lines covered (98.88%)

199.59 hits per line