go-kit / kit / 1933

51%

push

travis-ci

kitgen implementation (#589)

* cmd/kitgen: parse

* First stymie

* Sketch developing

* Broken sketch.

* Further progress - still doesn't build

* Need to collect ast.Exprs, not strings

* Running downhill.

* sd: add Stop method to Instancer interface

Every implementation (modulo mock/test impls) already provided this
method, and so it makes sense to lift it to the interface definition.

Closes #566.

* Fruitful avenue. Committing for travel.

* Needs uniquify for varnames

* Track gauge values and support default tags for dogstatsd

Dogstatsd doesn't support sending deltas for gauges, so we must
maintain the raw gauge value ourselves.

* Service generation tests work

* add failing test for cloudwatch metrics, that are not reset

* Refactor cloudwatch: Reset().Walk() on every Send(), like influx impl does.

Note there is a breaking API change, as the cloudwatch object now has optional parameters.

* Tolerate that there may not be any lables, if the teststat.FillCounter() did not add any samples.

* Use Cloudwatch options in the struct itself, which is cleaner

* sd: fix TestDefaultEndpointer flake, hopefully

* util/conn: more detail for flaky test

* removed deprecated functions

changed `NewContext -> NewOutgoingContext` and `FromContext ->
FromIncomingContext` as described in
[metadta](https://github.com/grpc/grpc-go/blob/master/metadata/metadata.go)

* Functions extracted from inline codefile

* Cleaner/easier way for user to specify Cloudwatch metric percentiles.

* fix test to read quantile metrics with p prefix

* test cloudwatch.WithPercentiles()

* Handles anonymous fields for all parts of interface

* Handles underscore param names, produces compile-able code

* do not prefix metrics with 'p', just like it was previously.

* Fix for dogstatsd metrics with default tags and no labelValues

Signed-off-by: James Hamlin <james@goforward.com>

* Converted flat to a layout ... (continued)

1451 of 1451 new or added lines in 11 files covered. (100.0%)

3840 of 4873 relevant lines covered (78.8%)

70402.92 hits per line