grondo / lua-affinity / 14

95%

Pull #3

travis-ci

lua-affinity: improve overflow detection

Problem: lua-affinity overflow test fails on 32-bit i686
system, returning 0xff instead of an overflow value.

On this system MAX_LUAINT is 0xfffff0 (2^24 - 16).
The overflow test value is 0xffffffffffffffff (2^64 - 1).
Overflow occurs if the lua_tointeger() >= MAX_LUAINT.

The lua5.1 documentation says of lua_tointeger() that
"if the a number is not an integer it is truncated
in some unspecified way".

Assuming a number that is too large to represent as
an integer might be considered "not an integer",
perhaps that explains the odd result of 0xff?

Since lua_tonumber() returns a double with greater
range than lua_tointeger(), add a check that the
two functions return equal values.  They should
match if the number is a valid integer.

1 of 1 new or added line in 1 file covered. (100.0%)

434 of 456 relevant lines covered (95.18%)

7677.93 hits per line