• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

graphql / graphql-js / 2636
98%
master: 98%

Build:
Build:
LAST BUILD BRANCH: directives
DEFAULT BRANCH: master
Ran 30 Nov 2017 08:28PM UTC
Jobs 1
Files 166
Run time 15s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2636

push

travis-ci

leebyron
RFC: Descriptions as strings.

As discussed in https://github.com/facebook/graphql/pull/90

This proposes replacing leading comment blocks as descriptions in the schema definition language with leading strings (typically block strings).

While I think there is some reduced ergonomics of using a string literal instead of a comment to write descriptions (unless perhaps you are accustomed to Python or Clojure), there are some compelling advantages:

* Descriptions are first-class in the AST of the schema definition language.
* Comments can remain "ignored" characters.
* No ambiguity between commented out regions and descriptions.

Specific to this reference implementation, since this is a breaking change and comment descriptions in the experimental SDL have fairly wide usage, I've left the comment description implementation intact and allow it to be enabled via an option. This should help with allowing upgrading with minimal impact on existing codebases and aid in automated transforms.

3860 of 4342 branches covered (88.9%)

151 of 151 new or added lines in 9 files covered. (100.0%)

9385 of 9581 relevant lines covered (97.95%)

1230.2 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
100.0
src/language/parser.js
3
100.0
src/utilities/schemaPrinter.js
5
100.0
src/utilities/extendSchema.js
9
100.0
src/utilities/buildASTSchema.js
Jobs
ID Job ID Ran Files Coverage
1 2636.1 30 Nov 2017 08:28PM UTC 0
97.95
Travis Job 2636.1
Source Files on build 2636
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2636
  • 7ff4fe13 on github
  • Prev Build on rfc-docstring (#2632)
  • Next Build on rfc-docstring (#2638)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc