2629
98%
master: 98%

Ran 30 Nov 2017 05:42PM UTC

Jobs 1

Files 166

Run time 13s

Badge

Embed ▾

pending completion

Build # 2629

Build Type

push

travis-ci

Committed by

leebyron

Commit Message

RFC: Descriptions as strings.

As discussed in https://github.com/facebook/graphql/pull/90

This proposes replacing leading comment blocks as descriptions in the schema definition language with leading strings (typically block strings).

While I think there is some reduced ergonomics of using a string literal instead of a comment to write descriptions (unless perhaps you are accustomed to Python or Clojure), there are some compelling advantages:

* Descriptions are first-class in the AST of the schema definition language.
* Comments can remain "ignored" characters.
* No ambiguity between commented out regions and descriptions.

Specific to this reference implementation, since this is a breaking change and comment descriptions in the experimental SDL have fairly wide usage, I've left the comment description implementation intact and allow it to be enabled via an option. This should help with allowing upgrading with minimal impact on existing codebases and aid in automated transforms.

Run Details

3855 of 4337 branches covered (88.89%)

147 of 147 new or added lines in 9 files covered. (100.0%)

9379 of 9575 relevant lines covered (97.95%)

1230.64 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	src/__tests__/starWarsSchema.js
1	100.0	src/__tests__/starWarsData.js
1	100.0	src/graphql.js
1	100.0	src/error/GraphQLError.js
1	100.0	src/language/__tests__/visitor-test.js
1	100.0	src/type/__tests__/introspection-test.js
1	100.0	src/utilities/__tests__/assertValidName-test.js
1	100.0	src/validation/__tests__/DefaultValuesOfCorrectType-test.js
2	100.0	src/utilities/astFromValue.js
2	100.0	src/language/parser.js
2	100.0	src/validation/rules/KnownArgumentNames.js
2	100.0	src/subscription/mapAsyncIterator.js
2	100.0	src/utilities/__tests__/extendSchema-test.js
2	100.0	src/utilities/__tests__/typeComparators-test.js
3	100.0	src/utilities/schemaPrinter.js
3	100.0	src/type/__tests__/definition-test.js
3	100.0	src/type/__tests__/schema-test.js
3	100.0	src/validation/__tests__/OverlappingFieldsCanBeMerged-test.js
4	100.0	src/type/introspection.js
4	100.0	src/validation/rules/KnownDirectives.js
4	100.0	src/execution/execute.js
4	100.0	src/validation/__tests__/harness.js
4	100.0	src/subscription/__tests__/subscribe-test.js
5	100.0	src/utilities/extendSchema.js
5	100.0	src/execution/__tests__/variables-test.js
5	100.0	src/utilities/__tests__/buildClientSchema-test.js
6	100.0	src/utilities/__tests__/schemaPrinter-test.js
7	100.0	src/utilities/findBreakingChanges.js
9	100.0	src/execution/values.js
9	100.0	src/utilities/buildASTSchema.js
10	100.0	src/utilities/buildClientSchema.js
11	100.0	src/type/definition.js
13	100.0	src/utilities/__tests__/findBreakingChanges-test.js
49	100.0	src/type/__tests__/validation-test.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	2629.1	30 Nov 2017 05:42PM UTC	0	97.95	Travis Job 2629.1

Source Files on build 2629

Detailed source file information is not available for this build.

graphql / graphql-js / 2629
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2629

graphql / graphql-js / 2629 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2629

graphql / graphql-js / 2629
98%
master: 98%

README BADGES
x