Devex / article_json / 317
100%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 171
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
317

Pull #123

travis-ci

web-flow 
Rework algorithm to place additional elements

While the previous algorithm was better in saturating articles with
additional elements it did not perform well when placing a single
additional element into an article, this was always placed at the end.

Considering the known use-cases of this algorithm (placing ads or CTA
forms within an article), it seems more common that single elements are
placed than that the article is being saturated with additional
elements.

Outline of the new algorithm:
1. It calculates every how many characters (only considering paragraphs)
   an additional element should be inserted, given the number of
   additional elements provided
2. It then iterates over the existing elements within the article,
   inserting them into the resulting, merged article
3. As soon as it has passed the right amount characters, it checks if
   the current position is eligible for inserting an additional element
   (the previous element needs to be a paragraph and the following needs
   to be either a paragraph or a headline)
    a) If so, it inserts the additional element and recalculates in how
       many characters the next element should be inserted, based on the
       remaining number of characters and remaining additional elements
    b) If not, it keeps iterating over the article until it finds an
       eligible position and only then inserts the additional element
       and recalculates the number of characters until the next
       insertion
4. If there are still additional elements remaining which couldn't be
   inserted (due to not finding enough eligible positions), they are
   appended to the end of the article
Pull Request #123: Rework algorithm to place additional elements

4250 of 4250 relevant lines covered (100.0%)

38.11 hits per line

Jobs
ID Job ID Ran Files Coverage
1 317.1 (2.3) 171
100.0
 Travis Job 317.1
2 317.2 (ruby-head) 171
100.0
 Travis Job 317.2
Source Files on build 317
Coverage ∆ File Lines Relevant Covered Missed Hits/Line