4392
70%

Ran 20 Nov 2017 01:10PM UTC

Jobs 3

Files 214

Run time 5min

Badge

Embed ▾

pending completion

Build # 4392

Build Type

push

travis-ci

Committed by

pypt

Commit Message

Fix bug from original all_url_variants() implementation; test topic-inferred URL variants directly instead of just a helper

In original __get_topic_url_variants() implementation (dating back to
controversy mapper), the code was made to discard all the URL variants
previously found with URL normalization, etc. if at least one URL was
found to be amongst the topic stories.

For example, if before the call to __get_topic_url_variants(), the
function would have generated URL variants:

* http://localhost/?cruft=cruft&cruft2=cruft2
* http://localhost/

...and __get_topic_url_variants() were to find that one of the variants
(e.g. http://localhost) was in topic_links, it would discard all the
rest of the variants (the "?cruft=cruft&cruft2=cruft2" variant) and go
with only the variants found in topic_links.

Changes:

* Variants from topic_links are treated as any other variants and merged
into the variant set.
* Unit test tests all_url_variants() instead of
__get_topic_url_variants() to make sure that we're getting all of the
expected variants.

Run Details

8296 of 15199 relevant lines covered (54.58%)

1706.37 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4392.1 (MC_TEST_CHUNK=1)	20 Nov 2017 01:15PM UTC	42.98	Travis Job 4392.1
2	4392.2 (MC_TEST_CHUNK=2)	20 Nov 2017 01:10PM UTC	33.87	Travis Job 4392.2
4	4392.4 (MC_TEST_CHUNK=4)	20 Nov 2017 01:10PM UTC	41.17	Travis Job 4392.4

Source Files on build 4392

Detailed source file information is not available for this build.

berkmancenter / mediacloud / 4392
70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4392

berkmancenter / mediacloud / 4392 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4392

berkmancenter / mediacloud / 4392
70%

README BADGES
x