Diaoul / subliminal / 869
92%
master: 92%

LAST BUILD BRANCH: develop
DEFAULT BRANCH: master
Ran
Jobs 10
Files 28
Run time 14min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
869

push

travis-ci

web-flow 
When ServiceUnavailable, log error instead of exception (traceback) (#764)

* Don't log exception on 503 Service Unavailable but log error

503 status is not an unexpected error. Quite common btw
Also OpenSubtitle raises a xmlrpclib.ProtocolError when unavailable:
<ProtocolError for api.opensubtitles.org/xml-rpc: 503 Backend fetch failed>

Full traceback:

Unexpected error in provider 'opensubtitles'
Traceback (most recent call last):
  File "/home/osmc/Medusa/lib/subliminal/core.py", line 118, in list_subtitles_provider
    return self[provider].list_subtitles(video, provider_languages)
  File "/home/osmc/Medusa/lib/subliminal/core.py", line 68, in __getitem__
    provider.initialize()
  File "/home/osmc/Medusa/lib/subliminal/providers/opensubtitles.py", line 142, in initialize
    'subliminal v%s' % __short_version__))
  File "/usr/lib/python2.7/xmlrpclib.py", line 1233, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1591, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1273, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1321, in single_request
    response.msg,
ProtocolError: <ProtocolError for api.opensubtitles.org/xml-rpc: 503 Backend fetch failed>

* LegendasTV need a custom function as it returns 200 when unavailable

* Proper handle empty content in Addic7ed

Provider wrongful return a status of 304 Not Modified with an empty content
raise_for_status won't raise exception for that status code

* Review

2063 of 2272 relevant lines covered (90.8%)

9.07 hits per line

Jobs
ID Job ID Ran Files Coverage
1 869.1 (PARSER=native) 28
90.71
 Travis Job 869.1
2 869.2 (PARSER=lxml) 28
90.58
 Travis Job 869.2
3 869.3 (PARSER=native) 28
90.8
 Travis Job 869.3
4 869.4 (PARSER=lxml) 28
90.67
 Travis Job 869.4
5 869.5 (PARSER=native) 28
90.8
 Travis Job 869.5
6 869.6 (PARSER=lxml) 28
90.67
 Travis Job 869.6
7 869.7 (PARSER=native) 28
90.8
 Travis Job 869.7
8 869.8 (PARSER=lxml) 28
90.67
 Travis Job 869.8
9 869.9 (PARSER=native) 28
90.8
 Travis Job 869.9
10 869.10 (PARSER=lxml) 28
90.67
 Travis Job 869.10
Source Files on build 869
Coverage ∆ File Lines Relevant Covered Missed Hits/Line