411
84%

Ran 16 Nov 2017 06:29PM UTC

Jobs 1

Files 47

Run time 3s

Badge

Embed ▾

pending completion

Build # 411

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix bad tail state in LRU map on removal of last entry (#386)

On removal of the last entry from an LRU map, the entry is both _head
and _tail. The existing remove() implementation matched it against
_head, which was then updated to _head.next (null), but _tail was left
unmodified in a bad state.

Since _tail is not null, the next insertion into the newly-empty map
don't reset it. When the map size eventually exceeds the maximum size,
_removeLru() is called to evict _tail, resulting in a null-pointer
exception as _removeLru() attempts to get _tail.previous (null) and then
set .next on that.

Run Details

1207 of 1486 relevant lines covered (81.22%)

1.53 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	100.0		lib/src/collection/lru_map.dart

Jobs

ID	Job ID	Ran	Files	Coverage
1	411.1 (DARTANALYZER_FLAGS='--fatal-warnings --strong')	16 Nov 2017 06:29PM UTC	0	81.22	Travis Job 411.1

Source Files on build 411

Detailed source file information is not available for this build.

google / quiver-dart / 411
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 411

google / quiver-dart / 411 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 411

google / quiver-dart / 411
84%

README BADGES
x