sferik / twitter / 1693

99%

master: 3%

push

travis-ci

[6-stable] Add TCP keepalive in Twitter::Streaming::Connection (#856)

* Add TCP keepalive in Twitter::Streaming::Connection

Without correct TCP keepalive setup, the Twitter streaming client is
prone to hang on long-lived connections. This is due to the nature of
the protocol: a single request is made, then the client simply waits for
data to read on a socket. Without keepalive, it may be indistinguishable
to the client whether the connection has failed or there is simply no
data to read.

These changes add the ability to set TCP keepalive providing the OS
supports it. They also provide a set of sensible defaults to the
keepalive for this implementation, while disabled by default.

* Add tests around keepalive setup

13 of 13 new or added lines in 1 file covered. (100.0%)

2063 of 2075 relevant lines covered (99.42%)

215.01 hits per line