node-red / node-red-web-nodes / 427

71%

push

travis-ci

Feature/handle network failure in google node (#199)

* Update npm dependencies

Installed packages:
 - backoff

Updated packages:
 - sinon
 - should
 - nock
 - mocha

* Handle network errors during token refresh

Currently there is a bug when a network error occurs during obtaining access token. The error is not reported to the caller via the callback function, so the caller waits forever for the response.

Secondly this commit adds network error tolerance by retrying the failed HTTP request 4 times (resulting a total of 5 HTTP request). Furthermore it waits between retries using exponential backoff strategy according to this formula:

  delay = 100 * 9^n
  where
   - delay is the time passes between HTTP calls in milliseconds
   - n is the retry counter (starting from 0)

* Fix failing tests after npm package upgrade

* Handle network errors during Google API requests

Current code only handles token refresh error, but the main HTTP request
could fail also and should be retried as well.
This commit adds a handler which retries failed HTTP request 4 times
(resulting a total of 5 HTTP requests).

1274 of 2031 branches covered (62.73%)

112 of 112 new or added lines in 2 files covered. (100.0%)

2525 of 3517 relevant lines covered (71.79%)

14.7 hits per line