benmosher / eslint-plugin-import / 2351

94%

Pull #943

travis-ci

[patch] make no-extraneous-dependencies include only paths that can be resolved,
as only resolved paths can be reliably tested if they live in a `node_modules` folder.

Up until now, this rule assumed, that every package that lives in a `node_modules` folder
or *cannot be resolved* is an external package.
This happens because of [that line](https://github.com/benmosher/eslint-plugin-import/blob/master/src/core/importType.js#L32).

If project uses aliasing, or transforms imports, this assumption is wrong,
as they may not be resolvable by import plugin, but also, they should not be defined in package.json.

Changing `isExternalPath` will make any ordering lints unstable
(order may change depending if you ran `npm install` or not).

Using `import/ignore` setting does not make sense too, as it's used to ignore imports unknown to the plugin,
like .css files. But still, you may import a css file from a dependency, and this rule should check that.

929 of 1039 branches covered (89.41%)

3 of 3 new or added lines in 1 file covered. (100.0%)

1965 of 2045 relevant lines covered (96.09%)

679.65 hits per line