TryGhost / Ghost-Admin / 3199

70%

push

travis-ci

🐛 Fixed "Someone else is editing" errors showing when no-one else is editing (#901)

closes https://github.com/TryGhost/Ghost/issues/8969

Collision detection errors were appearing incorrectly because the save routines in the post settings menu bypass the sequential saves in the main editor controller and so are prone to having stale data if a previous save is still in progress.

- added a new `savePost` task that is part of the `saveTasks` group so that all post saves are sequential
- pass the `savePost` task to the `{{gh-post-settings-menu}}` component
- use `savePost` task in `gh-post-settings-menu` instead of calling `save()` directly on the model instance

1700 of 2634 branches covered (64.54%)

26 of 26 new or added lines in 2 files covered. (100.0%)

4056 of 5546 relevant lines covered (73.13%)

42.44 hits per line