broadinstitute / firecloud-orchestration / 3350

64%

push

travis-ci

GAWB-1303: Remove passthroughAllPaths (#516)

* Remove redundant passthrough method

* /api/notifications/general working without passthroughAllPaths

* Notifications APIs working without passthroughAllPaths

* Refactored NotificationsApiService routes to make them self-documenting

* Added negative test cases to NotificationsApiServiceSpec and minor refactoring around it

* Renamed an input argument that could collide with a reserved Spray name

* Added corner-case negative tests to NotificationsApiServiceSpec

* Minor refactoring of SubmissionService*

* Added test for /api/submissions/queueStatus

* SubmissionService no longer uses passthroughAllPaths()

* passthroughAllPaths() removed from the last holdout (PassthroughDirectivesSpec)

* RestPath wildcarding is removed from BillingService and its test is updated accordingly

* Removed unused methods from PassthroughDirectivesSpec

* Negative test case for NotificationsApiService

* Fixed NotificationsApiServiceNegativeSpec and added more cases

* Added ServiceSpecSpec and a negative Spec for SubmissionService with one case failing

* Added negative test for '/api/workspaces/{workspaceNamespace}/{workspaceName}/submissions/validate'

* Added tests to SubmissionServiceNegativeSpec

* Removed OPTIONS verb from ServiceSpec.allHttpMethods

* Fixed a bug in SubmissionService and added test

* Added tests for /workspaces/*/*/submissions/validate API

* Added tests for /workspaces/*/*/submissions/*/workflows/* API

* Added tests for /workspaces/*/*/submissions/*/workflows/*/outputs API

* Added a negative spec for BillingService

* Remove unnecessary query parameter passthrough

* Clean-up around unnecessary 'requestCompression' parameters

* Added reference to JIRA for the issue around SubmissionService 'validate' URI

64 of 64 new or added lines in 7 files covered. (100.0%)

1993 of 2745 relevant lines covered (72.6%)

0.73 hits per line