Adobe-Consulting-Services / acs-aem-commons / 2177

57%

Pull #1156

travis-ci

<a href="https://github.com/Adobe-Consulting-Services/acs-aem-commons/commit/<a class=hub.com/Adobe-Consulting-Services/acs-aem-commons/commit/da8f30c59c90eca047a7541ce1d2bbabf6a69041">da8f30c59<a href="https://github.com/Adobe-Consulting-Services/acs-aem-commons/commit/da8f30c59c90eca047a7541ce1d2bbabf6a69041">&quot;&gt;Removing possible empty initialization of Granite.author

https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/</a><a class="double-link" href="https://github.com/Adobe-Consulting-Services/acs-aem-commons/commit/<a class="double-link" href="https://github.com/Adobe-Consulting-Services/acs-aem-commons/commit/905efac7fda3509f5535c05fc60fd2f5eb776846">905efac7f</a>">905efac7f</a><a href="https://github.com/Adobe-Consulting-Services/acs-aem-commons/commit/da8f30c59c90eca047a7541ce1d2bbabf6a69041">/content/src/main/content/jcr_root/apps/acs-commons/touchui-widgets/source/touchui-limit-parsys.js#L157

If someone who helped contribute to this item can help verify, that would be great!  Not positive why this initialization is there, and it&#39;s causing issues.

This line causes Granite.author to be initialized no matter what.  However, in all.js&#39;s setup of the file uploader, Granite.author (called ns.author there) is checked for initialization before proceeding.  Its empty initialization, then, breaks file uploader dialogs that are loaded in fullscreen dialogs.

For example, try loading up we.retail on a server with ACS commons installed, then try editing any image while your window is small enough that the editor opens in a full-screen separate URL.  The image uploader will not function due to a console error here:

`    function getAllowUploadFromDesign(element) {
        // In case the dialog has been opened outside of the Editor context, be conservative and restrict the upload
        if (!ns.author) {
            return;
        }`

This is not the case on any server where the above linked line has been removed. 

Seems like any lines above referencing gAuthor already must be resilient enough to not need further error handling since they would already be failing on the empty object, so I'm just turning off the empty initialization here.

5755 of 18509 relevant lines covered (31.09%)

1.55 hits per line