402
81%

Ran 29 Oct 2017 06:31PM UTC

Jobs 2

Files 99

Run time 6min

Badge

Embed ▾

pending completion

Build # 402

Build Type

push

travis-ci

Committed by

azat

Commit Message

Fix crashing http server when callback do not reply in place

General http callback looks like:
  static void http_cb(struct evhttp_request *req, void *arg)
  {
    evhttp_send_reply(req, HTTP_OK, "Everything is fine", NULL);
  }

And they will work fine becuase in this case http will write request
first, and during write preparation it will disable *read callback* (in
evhttp_write_buffer()), but if we don't reply immediately, for example:
  static void http_cb(struct evhttp_request *req, void *arg)
  {
    return;
  }

This will leave connection in incorrect state, and if another request
will be written to the same connection libevent will abort with:
  [err] ../http.c: illegal connection state 7

Because it thinks that read for now is not possible, since there were no
write.

Fix this by disabling EV_READ entirely. We couldn't just reset callbacks
because this will leave EOF detection, which we don't need, since user
hasn't replied to callback yet.

Reported-by: Cory Fields <cory@coryfields.com>

Run Details

10832 of 13456 relevant lines covered (80.5%)

780509.33 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	402.1 (EVENT_BUILD_METHOD=cmake EVENT_CMAKE_OPTIONS="-DEVENT__COVERAGE=ON -DCMAKE_BUILD_TYPE=debug" COVERALLS=yes)	29 Oct 2017 06:38PM UTC	0	80.5	Travis Job 402.1
2	402.2 (EVENT_BUILD_METHOD=cmake EVENT_CMAKE_OPTIONS="-DEVENT__COVERAGE=ON -DCMAKE_BUILD_TYPE=debug" COVERALLS=yes)	29 Oct 2017 06:31PM UTC	0	0.0	Travis Job 402.2

Source Files on build 402

Detailed source file information is not available for this build.

libevent / libevent / 402
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 402

libevent / libevent / 402 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 402

libevent / libevent / 402
81%

README BADGES
x