332
74%

Ran 20 Oct 2017 05:34PM UTC

Jobs 2

Files 46

Run time 32s

Badge

Embed ▾

pending completion

Build # 332

Build Type

Pull #5

travis-ci

Committed by

web-flow

Commit Message

Improve AbstractSource, DatabaseSource, Model

Changes:
- Documented class properties and methods
- Revised methods and internal variables
- Reorganized location of certain methods

Changes `ModelInterface`
- Added missing `hasProperty()` method to `ModelInterface`

Changes `AbstractModel`:
- Added array type-hint to relavant methods

Changes `AbstractSource`
- Simplified `$pagination` usage
- Refactored case-transformation for `getter()` and `setter()`
- Added support for optionally passing data to `createFilter()`, `createOrder()`, and `createPagination()`

Changes `DatabaseSource`:
- Replaced class constant `DEFAULT_DB_TYPE` with `MYSQL_DRIVER_NAME`
- Added class constant `SQLITE_DRIVER_NAME`
- Use driver name constants where needed
- Added `hasTable()` method
- Added `sqlFrom()` method
- Use `Expression::quoteIdentifier()`
- Added support for converting basic expressions into their DatabaseExpression equivalent

Pull Request Pull Request #5: Refactor Filter, Order, Pagination

Run Details

986 of 986 new or added lines in 13 files covered. (100.0%)

0 of 3734 relevant lines covered (0.0%)

0.0 hits per line

New Missed Lines in Diff

Lines	∆	File
14		src/Charcoal/Source/Database/DatabaseExpression.php
24	-21.12%	src/Charcoal/Loader/CollectionLoader.php
24	-80.0%	src/Charcoal/Source/Database/DatabasePagination.php
42		src/Charcoal/Source/Expression.php
42	-60.0%	src/Charcoal/Source/Pagination.php
61	-63.46%	src/Charcoal/Source/Database/DatabaseFilter.php
63	-54.0%	src/Charcoal/Source/Database/DatabaseOrder.php
64	-36.51%	src/Charcoal/Source/StorableTrait.php
82	-60.3%	src/Charcoal/Source/Filter.php
83	-46.85%	src/Charcoal/Source/Order.php
101		src/Charcoal/Source/ExpressionFieldTrait.php
141	-57.43%	src/Charcoal/Source/AbstractSource.php
245	-49.48%	src/Charcoal/Source/DatabaseSource.php

Uncovered Existing Lines

Lines	∆	File
6	-37.5%	src/Charcoal/Validator/ValidatableTrait.php
7	-41.18%	src/Charcoal/Source/SourceConfig.php
8	-25.0%	src/Charcoal/Model/AbstractMetadata.php
9	-52.94%	src/Charcoal/Model/ModelValidator.php
10	-20.0%	src/Charcoal/Model/Service/ModelBuilder.php
13	-56.52%	src/Charcoal/Model/Service/ModelLoaderBuilder.php
15	-63.46%	src/Charcoal/Source/Database/DatabaseFilter.php
22	-50.0%	src/Charcoal/Model/ModelMetadata.php
22	-54.0%	src/Charcoal/Source/Database/DatabaseOrder.php
24	-80.0%	src/Charcoal/Source/Database/DatabasePagination.php
30	-52.63%	src/Charcoal/Model/DescribableTrait.php
32	-46.85%	src/Charcoal/Source/Order.php
34	-51.52%	src/Charcoal/Source/DatabaseSourceConfig.php
35	-33.33%	src/Charcoal/Model/Service/ModelLoader.php
37	-60.0%	src/Charcoal/Source/Pagination.php
40	-57.14%	src/Charcoal/Validator/AbstractValidator.php
47	-60.26%	src/Charcoal/Validator/ValidatorResult.php
61	-67.74%	src/Charcoal/Model/ServiceProvider/ModelServiceProvider.php
65	-36.51%	src/Charcoal/Source/StorableTrait.php
96	-60.3%	src/Charcoal/Source/Filter.php
104	-58.76%	src/Charcoal/Model/Collection.php
118	-46.46%	src/Charcoal/Model/Service/MetadataLoader.php
133	-57.43%	src/Charcoal/Source/AbstractSource.php
137	-49.48%	src/Charcoal/Source/DatabaseSource.php
159	-21.12%	src/Charcoal/Loader/CollectionLoader.php
166	-38.84%	src/Charcoal/Model/AbstractModel.php

Jobs

ID	Job ID	Ran	Files	Coverage
2	332.2	20 Oct 2017 05:34PM UTC	46	0.0	Travis Job 332.2
3	332.3	20 Oct 2017 05:35PM UTC	46	0.0	Travis Job 332.3

Source Files on build 332

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

locomotivemtl / charcoal-core / 332
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 332

locomotivemtl / charcoal-core / 332 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 332

locomotivemtl / charcoal-core / 332
74%

README BADGES
x