328
74%

Ran 20 Oct 2017 03:51PM UTC

Jobs 3

Files 46

Run time 1min

Badge

Embed ▾

pending completion

Build # 328

Build Type

Pull #5

travis-ci

Committed by

web-flow

Commit Message

Improve AbstractSource and DatabaseSource

Changes:
- Documented class properties and methods
- Revised methods and internal variables
- Reorganized location of certain methods

Changes `AbstractSource`
- Simplified `$pagination` usage
- Refactored case-transformation for `getter()` and `setter()`

Changes `DatabaseSource`:
- Replaced class constant `DEFAULT_DB_TYPE` with `MYSQL_DRIVER_NAME`
- Added class constant `SQLITE_DRIVER_NAME`
- Use driver name constants where needed
- Added `hasTable()` method
- Added `sqlFrom()` method
- Use `Expression::quoteIdentifier()`

# Conflicts:
#	src/Charcoal/Source/SourceInterface.php

Pull Request Pull Request #5: Refactor Filter, Order, Pagination

Run Details

966 of 966 new or added lines in 13 files covered. (100.0%)

1792 of 3710 relevant lines covered (48.3%)

3.42 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
7	50.0		src/Charcoal/Source/Database/DatabaseExpression.php
9	61.22	-18.78%	src/Charcoal/Source/Database/DatabasePagination.php
12	67.33		src/Charcoal/Source/Expression.php
13	76.92	13.46%	src/Charcoal/Source/Database/DatabaseFilter.php
14	65.12	5.12%	src/Charcoal/Source/Pagination.php
16	67.39	13.39%	src/Charcoal/Source/Database/DatabaseOrder.php
19	72.92	12.62%	src/Charcoal/Source/Filter.php
20	21.12	0.0%	src/Charcoal/Loader/CollectionLoader.php
26	72.87	26.02%	src/Charcoal/Source/Order.php
39	36.51	0.0%	src/Charcoal/Source/StorableTrait.php
43	57.43		src/Charcoal/Source/ExpressionFieldTrait.php
51	52.45	-4.98%	src/Charcoal/Source/AbstractSource.php
103	49.25	-0.24%	src/Charcoal/Source/DatabaseSource.php

Uncovered Existing Lines

Lines	Coverage	∆	File
5	76.92	13.46%	src/Charcoal/Source/Database/DatabaseFilter.php
6	72.87	26.02%	src/Charcoal/Source/Order.php
7	67.39	13.39%	src/Charcoal/Source/Database/DatabaseOrder.php
9	61.22	-18.78%	src/Charcoal/Source/Database/DatabasePagination.php
12	65.12	5.12%	src/Charcoal/Source/Pagination.php
27	72.92	12.62%	src/Charcoal/Source/Filter.php
34	38.84	0.0%	src/Charcoal/Model/AbstractModel.php
39	36.51	0.0%	src/Charcoal/Source/StorableTrait.php
79	52.45	-4.98%	src/Charcoal/Source/AbstractSource.php
95	49.25	-0.24%	src/Charcoal/Source/DatabaseSource.php
116	21.12	0.0%	src/Charcoal/Loader/CollectionLoader.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	328.1	20 Oct 2017 03:51PM UTC	46	69.16	Travis Job 328.1
2	328.2	20 Oct 2017 03:51PM UTC	46	0.0	Travis Job 328.2
3	328.3	20 Oct 2017 03:53PM UTC	46	0.0	Travis Job 328.3

Source Files on build 328

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

locomotivemtl / charcoal-core / 328
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 328

locomotivemtl / charcoal-core / 328 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 328

locomotivemtl / charcoal-core / 328
74%

README BADGES
x