tpm2-software / tpm2-tools / 926

0%

push

travis-ci

<a href="https://github.com/01org/tpm2-tools/commit/<a class=hub.com/tpm2-software/tpm2-tools/commit/1e1ba978f7ab87403c0e305862d89dae8688fa61">1e1ba978f<a href="https://github.com/tpm2-software/tpm2-tools/commit/1e1ba978f7ab87403c0e305862d89dae8688fa61">&quot;&gt;test: tpm2_createpolicy: explicitly define a base when comparing hex values

If the base is omitted in an arithmetic expression bash assumes a base 10,
unless the constant starts with a 0 or 0x. In these cases, base 8 and 16
are used respectively.

So the test was only working because assumes a PCR0 value of 3, which
has the same value in both bases, but this isn&amp;#39;t true for all values and
will lead to the following issue:

./test_tpm2_createpolicy.sh: line 57: [[:
&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/01org/tpm2-tools/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/01org/tpm2-tools/commit/<a class=hub.com/tpm2-software/tpm2-tools/commit/9872964b9b40cdd0363fcd6af8c267c9cb34200b">9872964b9">9872964b9</a><a href="https://github.com/01org/tpm2-tools/commit/1e1ba978f7ab87403c0e305862d89dae8688fa61">: value too great for base
(error token is &quot;9872964b9b40cdd0363fcd6af8c267c9cb34200b&quot;)
Failure: Creating Policy Digest with PCR policy for index 0 and sha1
pcr index hash

Fix this by explicitly define a base 16 so bash know that the constant
value is an hexadecimal number.

Signed-off-by: Jia Zhang &lt;qianyue.zj@alibaba-inc.com&gt;</a>

3720 of 5526 relevant lines covered (67.32%)

36.12 hits per line