netceteragroup / girders-elements / 189

83%

push

travis-ci

Refresh effect, explicit read actions, better HTTP methods (#66)

* A new `readRefresh` action and a corresponding effect has been added. Triggering this action allows one to *refresh* an already read element. 
   * The effect will expose a `refreshing` property in the element's metadata while the refresh is running (neat for showing a loading indicator)
   * Read Failures are ignored (logged; we might update the metadata if this becomes a requirement)

* Reads have been re-implemented in terms of effects and udpates and *redux-saga* has been dropped as a dependency 🎉 
* Explicit action types have been added for all the read actions (found in `actions.types.reads`). Explicit action creators are added as well in `actions` for `read` and `readRefresh`.
* The http module has been touched up
  * `http.execute` method for running arbitrary http calls
  * `http.get` and `http.post` have been added
* Effects and read log errors better 

BREAKING CHANGE: 

* read action types have changed. Now are namespaced and can be found in `actions.types.read`. If you had any middleware listening on these actions, you might want to check it.
* To better support API growth, he signature of readers has changed from `(string, boolean) => Promise<ReadResponse>` to `(string, object) => Promise<ReadResponse>`
   * previously a boolean flag indicating whether the read should issue a revalidating http request was passed as a second argument; now this flag can be found inside the second arg like so: 
```
 function httpRead(uri, opts) {
   const { revalidate } = opts
  //...
}
```

258 of 399 branches covered (64.66%)

714 of 864 relevant lines covered (82.64%)

40.43 hits per line