229
100%

Ran 11 Oct 2017 11:48AM UTC

Jobs 2

Files 120

Run time 21s

Badge

Embed ▾

pending completion

Build # 229

Build Type

Pull #95

travis-ci

Committed by

web-flow

Commit Message

Add `custom_element_tags` to AMP exporter and refactor library lookup

By adding `ArticleJSON::Export::AMP::Exporter#custom_element_tags`
the user can now get a list of all used libraries (e.g. to check if one
should manually include an additional `iframe` library for an element
used outside of the article).

By refactoring the logic like this, we now also no longer need to parse
the AMP element before being able to get a list of all its required
custom elements.

The specs for `ArticleJSON::Export::AMP::Exporter.amp_libraries` still
pass (only some spacing had to be fixed). Therefore, the (tested) API of
the class remains the same.

`ArticleJSON::Export::AMP::Elements::Base.amp_library` (was untested)
has been removed and replaced with `.custom_element_tags` which now
returns a list of all custom tags used by the element.

Pull Request Pull Request #95: Refactor AMP library resolving

Run Details

2867 of 2868 relevant lines covered (99.97%)

33.22 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	229.1 (2.3)	11 Oct 2017 11:48AM UTC	120	99.97	Travis Job 229.1
2	229.2 (ruby-head)	11 Oct 2017 11:48AM UTC	120	99.97	Travis Job 229.2

Source Files on build 229

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

Devex / article_json / 229
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 229

Devex / article_json / 229 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 229

Devex / article_json / 229
100%

README BADGES
x