3209

Ran 10 Oct 2017 02:09PM UTC

Jobs 1

Files 81

Run time 8s

Badge

Embed ▾

pending completion

Build # 3209

Build Type

push

travis-ci

Committed by

mvdan

Commit Message

storage: a couple of redis cleanups

First, don't make all the methods use pointer receivers. None of them
modify the struct, and the struct itself is tiny - just a string and two
bools, which should total three ints. This should mean a slight memory
and performance win, as we don't have to allocate as many objects and we
don't have to jump around memory as much.

Second, refactor GetRelevantClusterReference into a method with a
shorter name, making the code more understandable and simpler.

While replacing RedisCluster pointers with structs, I also noticed how
RedisNotificationHandler could discard notifications if the store wasn't
initialised. Instead, synchronously set up the store, so we know it has
been set up. This is not a problem, given that Connect doesn't actually
block connecting to all the hosts.

Coverage Stats

5861 of 12799 relevant lines covered (45.79%)

0.5 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	3209.2 (LATEST_GO=true)	10 Oct 2017 02:09PM UTC	0	45.79	Travis Job 3209.2

Source Files on build 3209

Detailed source file information is not available for this build.

TykTechnologies / tyk / 3209

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3209

TykTechnologies / tyk / 3209

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3209

README BADGES
x