1192
93%
master: %

Ran 21 Oct 2014 05:42PM UTC

Jobs 1

Files 85

Run time 39s

Badge

Embed ▾

pending completion

Build # 1192

Build Type

push

travis-ci

Committed by Karthik Gururaj

Commit Message

Modified operator == in IndividualFieldValue to use iterators which
take care of bcf_*_vector_end values implicitly
A more serious bug in the previous implementation of the == operator was
in the way string fields were handled. Points to remember for string
fields:
1. The size() function returns the number of characters allocated for the string.
2. The variable m_num_bytes also stores the number of characters
allocated for the string (same as size())
3. When operator[i] is called for string fields, the address that is
accessed is m_format_ptr->p + i*m_num_bytes (not m_format_ptr->p + i).
The address accessed is outside the original allocated memory.

Moral of the story: use iterators always, or remember the intricacies of
string v/s other types of fields.

Similar fix for SharedField also

Run Details

1384 of 1483 relevant lines covered (93.32%)

934.81 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	1192.2	21 Oct 2014 05:42PM UTC	0	93.32	Travis Job 1192.2

Source Files on build 1192

Detailed source file information is not available for this build.

broadinstitute / gamgee / 1192
93%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1192

broadinstitute / gamgee / 1192 93% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1192

broadinstitute / gamgee / 1192
93%
master: %

README BADGES
x