ansible / tower-cli / 708

64%

Pull #394

travis-ci

make combine_files() work with UTF-8 encoded files

setup.py might fail on Python 3 in non-UTF8 environments while parsing
HISTORY.rst or README.rst which are not required to be ASCII-only with:

    UnicodeDecodeError: 'ascii' codec can't decode …

We could also require the files to be plain ASCII, but it sounds not the
right thing to do in the 21st century.

Simple reproducer:

    % LC_ALL=C python3 setup.py
    Traceback (most recent call last):
      File "setup.py", line 126, in <module>
        long_description=combine_files('README.rst', 'HISTORY.rst'),
      File "setup.py", line 112, in combine_files
        file_contents.append(f.read())
      File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2132: ordinal not in range(128)

845 of 948 branches covered (89.14%)

2615 of 2906 relevant lines covered (89.99%)

4.49 hits per line