red-hat-storage / rhcephpkg / 447

94%

Pull #154

travis-ci

patch: improve check for modified .patch files

If a project has a .gitignore file that ignores new .patch files in the
tree, `rhcephpkg patch` will write new .patch files locally but fail to
commit them to dist-git. The debian/changelog bump is there, and the
debian/patches/series file change is there, but the .patch files
themselves are missing from the Git commit.

Before `rhcephpkg patch` does the Git commit, it calls
read_git_debian_patches_status() as a pre-flight sanity-check in order
to verify that some .patch file has changed.

Prior to this commit, read_git_debian_patches_status() would return any
change to the debian/patches/series file as well as any .patch files.
This means that the pre-flight check would pass, even if Git was not
going to commit the .patch files themselves.

Make read_git_debian_patches_status() explicitly check for .patch file
changes (implicitly ignoring the debian/patches/series file changes).

This will lead `rhcephpkg patch` to quit with an error if a .gitignore
file happens to be ignoring .patch files.

5 of 5 new or added lines in 1 file covered. (100.0%)

709 of 759 relevant lines covered (93.41%)

3.7 hits per line