• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

CleverRaven / Cataclysm-DDA / 2327
33%

Build:
DEFAULT BRANCH: master
Ran 05 Oct 2017 07:16AM UTC
Jobs 1
Files 394
Run time 17s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2327

push

travis-ci

kevingranade
Encapsulate item::bday (#22060)

* Remove unused variable last_bday.

It is set (twice), but never actually read. And the removed loop itself is pointless as well, all it did was setting `last_bday` (which is never read). The condition and the loop itself don't have any side effects.

* Encapsulate item::bday

Make it private. Add four functions to access it:
- to get and set the birthday (a point in time) and,
- to get and set the age of the item (a time duration).

Use whatever is more convenient, e. g. when setting the birthday to the current turn, just call `set_age(0)`.

And yes, the change in activity_handlers.cpp is *correct*. The variable is misnamed. It is actually used as the birthday of the item (used for the constructor of new items).

23223 of 102932 relevant lines covered (22.56%)

69092.95 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2327.1 (COMPILER=g++-4.8 CODE_COVERAGE=true) 05 Oct 2017 07:16AM UTC 0
22.56
Travis Job 2327.1
Source Files on build 2327
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2327
  • c1e6d12f on github
  • Prev Build on master (#2319)
  • Next Build on master (#2328)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc