2327
33%

Ran 05 Oct 2017 07:16AM UTC

Jobs 1

Files 394

Run time 17s

Badge

Embed ▾

pending completion

Build # 2327

Build Type

push

travis-ci

Committed by

kevingranade

Commit Message

Encapsulate item::bday (#22060)

* Remove unused variable last_bday.

It is set (twice), but never actually read. And the removed loop itself is pointless as well, all it did was setting `last_bday` (which is never read). The condition and the loop itself don't have any side effects.

* Encapsulate item::bday

Make it private. Add four functions to access it:
- to get and set the birthday (a point in time) and,
- to get and set the age of the item (a time duration).

Use whatever is more convenient, e. g. when setting the birthday to the current turn, just call `set_age(0)`.

And yes, the change in activity_handlers.cpp is *correct*. The variable is misnamed. It is actually used as the birthday of the item (used for the constructor of new items).

Run Details

23223 of 102932 relevant lines covered (22.56%)

69092.95 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2327.1 (COMPILER=g++-4.8 CODE_COVERAGE=true)	05 Oct 2017 07:16AM UTC	0	22.56	Travis Job 2327.1

Source Files on build 2327

Detailed source file information is not available for this build.

CleverRaven / Cataclysm-DDA / 2327
33%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2327

CleverRaven / Cataclysm-DDA / 2327 33%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2327

CleverRaven / Cataclysm-DDA / 2327
33%

README BADGES
x