ethereum / web3.js / 2038

52%

1.x: 80%

push

travis-ci

Decouple wallet.length from other wallet functions (add, encrypt, clear) (#1079)

* Added wallet._findSafeIndex to prevent wallet.create overwrites.

* Added tests for wallet overwrite patch. Updated Chai to 4.0.

All tests pass with new test and new Chai.

* Strengthened test with inequility check. Changed naming for readability.

* Fixed similar issue with wallet.clear and wallet.encrypt.

The coupling of wallet.length to other wallet functions causes issues
when accounts have been previously removed.

* Added test for wallet encrypt/decrypt. Fixed wallet.encrypt

1076 of 1447 branches covered (74.36%)

21 of 21 new or added lines in 1 file covered. (100.0%)

2204 of 2570 relevant lines covered (85.76%)

1820.95 hits per line