ember-best-practices / eslint-plugin-ember-best-practices / 309

92%

push

travis-ci

Add missing tests (#91)

* Add missing tests

This adds two failing tests to highlight bugs and a passing but
previously missing test.

The missing test added is for calling `set` which was destructured from
`import Ember from 'ember'`

One failing test is to handle the case where `Ember.computed` is called
from an import that isn't named `Ember`, eg
```
import E from 'ember';
E.computed()
```

Another failing test illustrates that ember import bindings are
clobbered if followed by any other default import, as in:
```
import Ember from 'ember';
import AnythingElse from 'anywhere';
```

* Clean up no-side-effect-cp rule.

Fixes a number of the errors previously identified, as well as a few
additional ones (tests added in this commit).

216 of 254 branches covered (85.04%)

Branch coverage included in aggregate %.

419 of 447 relevant lines covered (93.74%)

42.05 hits per line