zhmcclient / zhmccli / 88
37%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 15
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
88

Pull #17

travis-ci

web-flow 
Added concept for function testing zhmccli + first testcases

Details:

Added a concept for function tests for the zhmc CLI:

- Added two functions in a utils module for invoking the 'zhmc' command:

  * call_zhmc_child(): Invokes the zhmc command as a child process.

  * call_zhmc_inline(): Invoke the cli() function of zhmc in the current
    Python process. This function allows for setting up a mocked environment.

- In the zhmccli code, added support for passing the FakedSession object
  for the mocked environment as a global variable of the zhmcclient_mock
  module. The expression to access the FakedSession object is passed
  as a string in the ZHMC_SESSION_ID environment variable.

- Enabled the zhmccli cli() function to be called multiple times in
  the same Python process, which is what testcases using call_zhmc_inline()
  will do. This enablement consists of this change:

  * Different setup of the logger handlers: Before this change, the
    new handler was added to the loggers that were specified. This causes
    write attempts to closed log files for stderr, because the loggers had
    stream handlers from previous invocations which pointed to meanwhile
    closed temp files for capturing stdout/stderr. With this change, all
    loggers are first reset to have exactly one NullHandler, and then
    the handlers for the specified loggers are added.

Fixed the error that CONSOLE_LOGGGER_NAME was removed from zhmcclient
in the branch that split out zhmccli, but was not added in zhmccli.

Added some initial function tests, for the 'info' subcommand and for
global command options. Removed the test_dummy.py file because we now have
real tests.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

tmp

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

fix for closed log file

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

fixed.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Pull Request #17: Fixes #5: Added concept for function testing zhmccli

813 of 2020 relevant lines covered (40.25%)

0.4 hits per line

Jobs
ID Job ID Ran Files Coverage
2 88.2 (PACKAGE_LEVEL=latest) 15
40.25
 Travis Job 88.2
Source Files on build 88
Coverage ∆ File Lines Relevant Covered Missed Hits/Line