marionettejs / backbone.marionette / 6393

100%

push

travis-ci

Use add at end perf only when sortWithCollection is false (#3471)

Because a collection can be modified without the full understanding on the collectionview, the optimistic adding that reduces perf is not ideal when `sortWithCollection: true`  This opens the door to all kinds of edge cases.  So we should only apply it when the collectionview itself is maintaining the sort.

However this brought up a related issue.  If a collection was `sortWithCollection: false` the _default_ `viewComparator` was still sorting with collection on add or update which mean that setting it to false only prevented a resort if `collection.sort()` was called directly, but not for any other circumstance.  If the collectionview is not maintaining the collection's sort, this prevents the sort from occurring at all.

853 of 884 branches covered (96.49%)

8 of 8 new or added lines in 1 file covered. (100.0%)

1718 of 1718 relevant lines covered (100.0%)

749.42 hits per line