TryGhost / Ghost-Admin / 3077

70%

push

travis-ci

🐛 Fixed search losing focus when removing search term (#883)

closes https://github.com/TryGhost/Ghost/issues/9075

- ensure we re-focus the input element after closing the dropdown so that it's not necessary to click on the search input again after using backspace
- removes unnecessary use of `run.scheduleOnce`
  - this was causing the error in TryGhost/Ghost#9075 because search was happening out of sync with the open/close of the dropdown in turn causing `ember-basic-dropdown` to try measuring non-existent elements
  - alternative fix would be to wrap each open/close, focus, and search call in separate `run.scheduleOnce('afterRender', ...)` calls
- remove use of `invokeAction`, it's not been necessary in Ember for a while now and we should be calling methods directly where possible for easier debugging

1583 of 2449 branches covered (64.64%)

3775 of 5220 relevant lines covered (72.32%)

41.04 hits per line