Throne3d / node-irc / 249

94%

Pull #40

travis-ci

Fix .join to use a comma-separated list per IRC spec

As per https://tools.ietf.org/html/rfc2812#page-16, the client is
permitted to use a comma-separated list to communicate the channels it
wishes to join to the server. This is as opposed to a space-separated
list, as stated in the docs, which fails to do anything but join the
first channel on the servers I tested it on.

The server is *not* permitted to do the same back to the client (though
it only "should not", as opposed to being explicitly forbidden from
doing so.).

This commit also adds tests for the `.join` method of the `irc.Client`
API.

266 of 437 branches covered (60.87%)

Branch coverage included in aggregate %.

36 of 36 new or added lines in 1 file covered. (100.0%)

598 of 793 relevant lines covered (75.41%)

258.11 hits per line