• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Throne3d / node-irc / 248
89%
master: 94%

Build:
Build:
LAST BUILD BRANCH: upgrade/deps-2021-04-24
DEFAULT BRANCH: master
Ran 26 Sep 2017 10:57PM UTC
Jobs 5
Files 5
Run time 19s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
248

push

travis-ci

Throne3d
Fix .join to use a comma-separated list per IRC spec

As per https://tools.ietf.org/html/rfc2812#page-16, the client is
permitted to use a comma-separated list to communicate the channels it
wishes to join to the server. This is as opposed to a space-separated
list, as stated in the docs, which fails to do anything but join the
first channel on the servers I tested it on.

The server is *not* permitted to do the same back to the client (though
it only "should not", as opposed to being explicitly forbidden from
doing so.).

This commit also adds tests for the `.join` method of the `irc.Client`
API.

266 of 437 branches covered (60.87%)

Branch coverage included in aggregate %.

598 of 793 relevant lines covered (75.41%)

258.11 hits per line

Jobs
ID Job ID Ran Files Coverage
1 248.1 26 Sep 2017 10:57PM UTC 0
70.24
Travis Job 248.1
2 248.2 26 Sep 2017 10:57PM UTC 0
70.24
Travis Job 248.2
3 248.3 26 Sep 2017 10:58PM UTC 0
70.24
Travis Job 248.3
4 248.4 26 Sep 2017 10:58PM UTC 0
70.24
Travis Job 248.4
5 248.5 26 Sep 2017 10:57PM UTC 0
70.24
Travis Job 248.5
Source Files on build 248
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #248
  • d15c7a13 on github
  • Prev Build on test/more (#246)
  • Next Build on test/more (#250)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc