897
78%
main: 61%

Ran 21 Sep 2017 03:52AM UTC

Jobs 2

Files 21

Run time 28min

Badge

Embed ▾

pending completion

Build # 897

Build Type

push

travis-ci

Committed by

deepakjois

Commit Message

Handle truncation while mmap-ing (esp. on Windows)

mmap on Windows works differntly from mmap on Linux.

* We cannot mmap to a size beyond the size of the file. So we need to
truncate to that size and then map.

* We cannot truncate a file while a section of it has been mapped.

This has implications for how we manage value logs. This change fixes
mmap-ing on Windows with the following changes:

* When badger.NewKV() function is called, which in turn calls
valueLog.Open() method, we don’t immediately mmap the writable log
files (read-only log files are not a problem). We mmap the writable log
after replay has happened.

* Whenever the valueLog.iterate() method is called, and it determines
that a file needs to be truncated - we need to either make sure that
there are no open mmaps, or we need to munmap and then re-map the file
after truncation.

* Whenever a writable log file is mmap-ed, its size increases to
ValueLogFileSize * 2 (because of truncation in y.Mmap() function). We
need to ensure that once it has filled up, it is truncated back to the
actual size before it is closed and opened as a read-only file. We also
need to truncate if back if the value log is closed before it fills up.

* Fix a few tests on AppVeyor that were running out of memory by
reducing ValueLogFileSize option value.

Fixes #212.

Run Details

3343 of 4262 relevant lines covered (78.44%)

62701.67 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	897.1	21 Sep 2017 03:52AM UTC	21	78.2	Travis Job 897.1
2	897.2	21 Sep 2017 04:21AM UTC	21	78.44	Travis Job 897.2

Source Files on build 897

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

dgraph-io / badger / 897
78%
main: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 897

dgraph-io / badger / 897 78% main: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 897

dgraph-io / badger / 897
78%
main: 61%

README BADGES
x