• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ethereum / pydevp2p / 392
88%

Build:
DEFAULT BRANCH: develop
Ran 13 Sep 2017 12:05PM UTC
Jobs 4
Files 17
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
392

Pull #82

travis-ci

web-flow
Don't try to send throug closed socket in NodeDiscovery

When stopping the services, and PeerManager is still alive after
NodeDiscovery was stopped, it may try to send some discovery messages.
This will cause DatagramServer.sendto to throw AttributeError, because
a closed DatagramServer doesn't have a `socket` attribute.

Prevent this, by checking if the DatagramServer is closed, and dropping
the message if it is.
Pull Request #82: Don't try to send through closed socket in NodeDiscovery

3 of 3 new or added lines in 1 file covered. (100.0%)

2114 of 2382 relevant lines covered (88.75%)

3.5 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
100.0
devp2p/discovery.py

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
devp2p/p2p_protocol.py
1
100.0
devp2p/protocol.py
3
100.0
devp2p/peermanager.py
Jobs
ID Job ID Ran Files Coverage
1 392.1 13 Sep 2017 12:05PM UTC 0
87.66
Travis Job 392.1
2 392.2 13 Sep 2017 12:08PM UTC 0
87.36
Travis Job 392.2
3 392.3 13 Sep 2017 12:06PM UTC 0
87.99
Travis Job 392.3
4 392.4 13 Sep 2017 12:05PM UTC 0
87.15
Travis Job 392.4
Source Files on build 392
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #392
  • Pull Request #82
  • PR Base - develop (#384)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc