1937
20%

Ran 13 Sep 2017 05:17AM UTC

Jobs 1

Files 8

Run time 1s

Badge

Embed ▾

pending completion

Build # 1937

Build Type

Pull #687

travis-ci

Committed by Max Spencer

Commit Message

THRIFT-2974 fix optional writeToParcel

Fix for [THRIFT-2974](https://issues.apache.org/jira/browse/THRIFT-2974?jql=text%20~%20%22optional%20writeToParcel%22) which causes NPEs whenever struct with an unset optional enum is written to an Android [`Parcel`](http://developer.android.com/reference/android/os/Parcel.html#writeInt%28int%29).

[Thrift IDL docs](https://thrift.apache.org/docs/idl#enum) specify that enum values must be greater than or equal to zero so we can write -1 to the parcel to represent an unset enum. The corresponding code for reconstructing the struct (see line 1728) uses the `TEnum.findByValue` method which will return `null` for any unused enum values, which will always include -1.

Pull Request Pull Request #687: THRIFT-2974 fix optional writeToParcel

Run Details

629 of 633 relevant lines covered (99.37%)

7.29 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
12	1937.12 (TEST_NAME="make cross (automake)" THRIFT_CROSSTEST_CONCURRENCY=6 CONFIG="--enable-tutorial=no --without-lua --without-haxe --without-d" ALL_DEPS="yes" MAKE_TARGET="cross" ERROR_LOG="test/log/unexpected_failures.log")	13 Sep 2017 05:17AM UTC	0	99.37	Travis Job 1937.12

Source Files on build 1937

Detailed source file information is not available for this build.

apache / thrift / 1937
20%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1937

apache / thrift / 1937 20%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1937

apache / thrift / 1937
20%

README BADGES
x