TykTechnologies / tyk / 2923

push

travis-ci

revproxy: refactor default transport

Remove the TykTransporter wrapper around the http.Transport. Its only
purpose was SetTimeout, which was only used once and was very limited -
it did not override the Dial family of methods.

Second, be consistent about overriding and using DialContext instead of
Dial. Dial is defined as deprecated, and many libraries including std
will ignore it if DialContext is set. For now, use context.TODO() when
calling, which will equal to the previous behavior.

Third, sync the default transport with http.DefaultTransport - namely,
adding fields like MaxIdleConns and DualStack.

Finally, use a separate http.Transport object per proxied request.
Before we were modifying and using a global in-place, which meant that
concurrent requests could run into race conditions and misbehave if
requiring different transport tweaks.

This also fixes one of the last two staticcheck warnings, stemming from
handler_websocket's use of net.Dial.

Updates #495 - we will need a consistent default transport to cache the
DNS queries, and this one seems logical.

24 of 24 new or added lines in 2 files covered. (100.0%)

5927 of 13504 relevant lines covered (43.89%)

0.48 hits per line