67
82%

Ran 11 Sep 2017 11:32AM UTC

Jobs 8

Files 16

Run time 2min

Badge

Embed ▾

pending completion

Build # 67

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fewer driver.ErrBadConn to prevent repeated queries (#302)

According to the database/sql/driver documentation, ErrBadConn should only
be used when the database was not affected. The driver restarts the same
query on a different connection, then.
The mysql driver did not follow this advice, so queries were repeated if
ErrBadConn is returned but a query succeeded.

This is fixed by changing most ErrBadConn errors to ErrInvalidConn.

The only valid returns of ErrBadConn are at the beginning of a database
interaction when no data was sent to the database yet.

Those valid cases are located the following funcs before attempting to write
to the network or if 0 bytes were written:

* Begin
* BeginTx
* Exec
* ExecContext
* Prepare
* PrepareContext
* Query
* QueryContext

Commit and Rollback could arguably also be on that list, but are left out as
some engines like MyISAM are not supporting transactions.

Tests in b/packets_test.go were changed because they simulate a read not
preceded by a write to the db. This cannot happen as the client has to send
the query first.

Run Details

2291 of 3019 relevant lines covered (75.89%)

116202.15 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	67.1	11 Sep 2017 11:32AM UTC	71.38	Travis Job 67.1
2	67.2	11 Sep 2017 11:32AM UTC	71.38	Travis Job 67.2
3	67.3	11 Sep 2017 11:32AM UTC	71.59	Travis Job 67.3
4	67.4	11 Sep 2017 11:32AM UTC	73.43	Travis Job 67.4
5	67.5	11 Sep 2017 11:34AM UTC	73.43	Travis Job 67.5
6	67.6 (DB=MYSQL57)	11 Sep 2017 11:34AM UTC	75.21	Travis Job 67.6
7	67.7 (DB=MARIA55)	11 Sep 2017 11:35AM UTC	74.47	Travis Job 67.7
8	67.8 (DB=MARIA10_1)	11 Sep 2017 11:35AM UTC	75.01	Travis Job 67.8

Source Files on build 67

Detailed source file information is not available for this build.

shogo82148 / mysql / 67
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 67

shogo82148 / mysql / 67 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 67

shogo82148 / mysql / 67
82%

README BADGES
x