772
76%
main: 61%

Ran 11 Sep 2017 04:55AM UTC

Jobs 2

Files 22

Run time 4min

Badge

Embed ▾

pending completion

Build # 772

Build Type

push

travis-ci

Committed by

deepakjois

Commit Message

Use mmap for reading values everywhere.

This change adds support for mmap-ing the writable value log file,
in addition to the read-only files. We mmap the files with the size
set to math.MaxUint32, which is the theoretical maximum size of the value
pointer offset.

It is not very clear what the implications of mmap-ing beyond the
size of the file is. The mmap manpage does not indicate anything
specific. Moreover, it also says:

> “The effect of changing the size of the underlying file of a mapping
on the pages that correspond to added or removed regions of the
file is unspecified.”

The approach used here is similar to what BoltDB is doing, so there
is some confidence that it is fine.

Other notable changes:

* Since we are doing mmap reads exclusively, we no longer need to
  pass around a slice to copy the buffer. So some methods signatures
  also changed as a result of that.

* Rename logFile.fdlock to logFile.lock because it is now used to guard
both file descriptor and the memory map.

* Add logFile.mmap() convenience method.

* Make logFile.readValueBytes() method take a callback for consuming
bytes.

Run Details

3164 of 4181 relevant lines covered (75.68%)

65784.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	772.1	11 Sep 2017 04:55AM UTC	22	75.46	Travis Job 772.1
2	772.2	11 Sep 2017 05:00AM UTC	22	75.68	Travis Job 772.2

Source Files on build 772

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

dgraph-io / badger / 772
76%
main: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 772

dgraph-io / badger / 772 76% main: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 772

dgraph-io / badger / 772
76%
main: 61%

README BADGES
x