npm / npm / 8653

93%

master: %

push

travis-ci

install: fix bug with rollback of failed optional packages on Windows

This change ensures an fsync after updating `package.json` on Windows,
which prevents an issue that intermittently occurs when rolling back a
package with many dependencies such as fsevents.

In testing it does not appear that fsync has as much of a performance
impact on Windows as it does on other platforms, so this should not affect
install times on Windows materially.

Fixes: #17671
Fixes: #18287
Fixes: #18453
Fixes: #18380
Fixes: #18441
PR-URL: https://github.com/npm/npm/pull/18458
Credit: @marcins
Reviewed-By: @iarna

3393 of 4832 branches covered (70.22%)

6480 of 7642 relevant lines covered (84.79%)

1473.23 hits per line