9406
88%
master: 87%

Ran 08 Sep 2017 07:13PM UTC

Jobs 1

Files 271

Run time 57s

Badge

Embed ▾

pending completion

Build # 9406

Build Type

push

travis-ci

Committed by

Gerold103

Commit Message

Add assert to CSV parser and explain its condition

Coverity Scan has found a possible bug in a CSV parser - dereferencing
of a null pointer.
But it is not possible. Lets explain:

According to Coverity, the null dereference is in CSV_IN_QUOTES
processing in csv_parse_impl.
But bufp (nullified pointer) can be set to null only in two cases:
CSV_NEWFIELD and CSV_OUT_OF_QUOTES.

In a case of CSV_NEWFIELD the parser sets the state to CSV_LEADING_SPACES and
on a next iteration it sets bufp to not null.

In a case of CSV_OUT_OF_QUOTES the parser can nullify bufp only
if is_end_of_line was true at the end of 'out_of_quotes' processing.
But it means, that is_end_of_line was true at the beginning of
processing too, because CSV_OUT_OF_QUOTES does not modify it.
And at the beggining, if is_end_of_line was true, then the state
is set to CSV_LEADING_SPACES. And on a next iteration bufp are set
to not null.

Closes #2692

Run Details

32811 of 37389 relevant lines covered (87.76%)

1077657.62 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	9406.4 (TARGET=coverage)	08 Sep 2017 07:13PM UTC	271	87.76	Travis Job 9406.4

Source Files on build 9406

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

tarantool / tarantool / 9406
88%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9406

tarantool / tarantool / 9406 88% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9406

tarantool / tarantool / 9406
88%
master: 87%

README BADGES
x