nats-io / gnatsd / 1677

91%

Pull #578

travis-ci

[FIXED] Override from command line not always working

There were some cases where override would not work. Any command
line parameter that would be set to the type default value (false
for boolean, "" for string, etc) would not be taken into account.

I moved all the flags parsing and options configuration into
a new function, which may help reduce code duplication in
NATS Streaming.

The other advantage of moving this in a function is that it
can now be unit tested.

I am also removing call to `RemoveSelfReference()` which attempted
to remove a route to self, which has been already solved at runtime
with detecting and ignoring a route to self.

This function would be invoked only when routes were defined in
the configuration file, not in the command line parameter.

Removing this call also solves an user issue (#577)

Resolves #574
Resolves #577

269 of 269 new or added lines in 2 files covered. (100.0%)

5862 of 6380 relevant lines covered (91.88%)

2579.73 hits per line