twitter / secureheaders / 1054

97%

push

travis-ci

Distinguish between source lists directives and non-source list directives (#354)

* Add more specific type support for non "source list" directives

Prior behavior treated anything that was an "array of stuff" as a "source
list". But, source lists are very specific and don't really have meaning for
some directives. For example, the sandbox directive take an array of values,
but they are very specific. They aren't URLs, don't support wildcard values,
etc. So, This commit extract those directives from being treated like source
lists and adds native support for the associated directive.

* Make overall naming more consistent and adds some polish

* Remove unnecessary nonce logic and special case OPT_OUT for source lists

97 of 97 new or added lines in 4 files covered. (100.0%)

2058 of 2150 relevant lines covered (95.72%)

637.74 hits per line